Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undoing a remove operation after commit does not update Database editor's views #2228

Closed
soininen opened this issue Aug 2, 2023 · 0 comments · Fixed by #2234
Closed

Undoing a remove operation after commit does not update Database editor's views #2228

soininen opened this issue Aug 2, 2023 · 0 comments · Fixed by #2234
Assignees
@soininen
Labels
bug Something isn't working
Milestone
V0.7

Comments

@soininen
Copy link
Contributor

soininen commented Aug 2, 2023

Steps to reproduce in Database editor:

  1. Remove an object which is used in relationships
  2. Commit changes
  3. Undo

The removed object and the removed relationships do not reappear in the corresponding tree views and the editor is left in an inconsistent state that may lead to crash if it is used for further modifications. Committing the undo action will add the object back to the database but not the relationships.
@soininen soininen added the bug Something isn't working label Aug 2, 2023
@soininen soininen added this to the V0.7 milestone Aug 2, 2023
@soininen soininen self-assigned this Aug 2, 2023
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 4, 2023
@soininen
Make referrers a property
0a12547 
The field needs to be accessed from outside.

Re spine-tools/Spine-Toolbox#2228
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 4, 2023
@soininen
Mark cache item as not-to-be-removed when readding
4be7c6f 
There may be items that are marked both as removed and to-be-removed
when undoing remove actions.

Re spine-tools/Spine-Toolbox#2228
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 4, 2023
@soininen
Return removed items
040265f 
Toolbox needs to know which items were removed when removing them
in cascade to be able to fully undo the removal.

Re spine-tools/Spine-Toolbox#2228
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 4, 2023
@soininen
Add deepcopy and non-cascade readd to CacheItem
82b2f22 
Re #spine-tools/Spine-Toolbox#2228
soininen added a commit that referenced this issue Aug 4, 2023
@soininen
Code cleanup, docstrings
5bd0da6 
No functional changes intended.

Re #2228
soininen added a commit that referenced this issue Aug 4, 2023
@soininen
Fix undoing remove actions after db commit
8d4e454 
Committing changes in Database editor does two things that were not
taken into account when undoing commands that removed items:

- The removed items were replaced in the database cache which made
  them distinct from the items stored in the undo command
- readd/update/remove callbacks from the new items were removed
  which prevented fetch parents from being notified that the items
  were readded

On readd, SpineDBWorker now gets the real cache item to work with.
It also rebinds the callbacks if necessary before actually readding
the item back.

Re #2228
soininen added a commit that referenced this issue Aug 4, 2023
@soininen
Fix undoing cascading removal after commit
9697c93 
Database items are physically gone from the database after committing,
so RemoveItemsCommand needs to know all removed items and their types,
not just the one user selected for removal. This information is now
propagated to RemoveItemsCommand from spinedb_api upon commit.

Re #2228
soininen added a commit that referenced this issue Aug 4, 2023
@soininen
Fix redoing db additions when items have referrers
352c36a 
AddItemsCommand should not readd items in cascade when redoing.
This fixes the command adding items that were not originally
added when the command was created.

Re #2228
This was referenced Aug 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
bug Something isn't working
Projects
None yet
Milestone
V0.7
Development

Successfully merging a pull request may close this issue.

Fix undo/redo in Database editor spine-tools/Spine-Toolbox
1 participant
@soininen