Improve support for undo/redo functionality in Toolbox #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field needs to be accessed from outside. Re spine-tools/Spine-Toolbox#2228
There may be items that are marked both as removed and to-be-removed when undoing remove actions. Re spine-tools/Spine-Toolbox#2228
Toolbox needs to know which items were removed when removing them in cascade to be able to fully undo the removal. Re spine-tools/Spine-Toolbox#2228
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of changes that are needed to fix issues with undo commands in Toolbox.
CacheItem.cascade_readd()now sets_to_removetoFalse. Unless I missed something, this is the only truly backwards-incompatible change.CacheItem.readd()adds items without adding their referrers. This allows redoing additions that have later received referrers. For example, redoing an 'add object class' command should only readd the object class, not its parameter definitions that were added later.CacheItem.deepcopy()can be used to create independent clones of CacheItems.Re spine-tools/Spine-Toolbox#2228
@manuelma Just a heads-up: this might interfere with the entity branch.
Checklist before merging