Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer Pivoted Source Type can hide bugs #2224

Closed
Tasqu opened this issue Aug 2, 2023 · 0 comments · Fixed by spine-tools/Spine-Database-API#257
Closed

Importer Pivoted Source Type can hide bugs #2224

Tasqu opened this issue Aug 2, 2023 · 0 comments · Fixed by spine-tools/Spine-Database-API#257
Assignees
Labels
bug Something isn't working Data import/export
Milestone

Comments

@Tasqu
Copy link
Member

Tasqu commented Aug 2, 2023

The Importer seems to have a bug where the Pivoted Source Type is displayed, but in actuality something else is saved in the importer specification. I had managed to create a situation where the importer specification editor displayed the following:
image
However, in reality, the importer specification .json had the following:
image
resulting in nonsense being imported into the DataStore.
I couldn't seem to figure out a way to see or change this error through the import specification editor in toolbox, as it refused to display the parameter value field as anything besides Pivoted.

I'm not sure how I managed to create this bug in the first place, but I imagine I could have accidentally entered Header in the Parameter Values field first when creating the original specification, before entering it a second time into the correct Parameter Names field.

@Tasqu Tasqu added bug Something isn't working Data import/export labels Aug 2, 2023
@jkiviluo jkiviluo added this to the V0.7 milestone Aug 3, 2023
@soininen soininen self-assigned this Aug 9, 2023
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 9, 2023
Import mappings should ignore the position of last mapping if
the mappings are pivoted. This did not happen, however, when
one of the other mappings was marked as header and there were
no explicitly set pivoted mappings. We now take this special
case into account.

Re spine-tools/Spine-Toolbox#2224
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 9, 2023
Mappings are not pivoted when only the leaf mapping has position
set to header.

Re spine-tools/Spine-Toolbox#2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Data import/export
Projects
None yet
3 participants