Treat pivoted leaf import mapping correctly even when its position is set to header #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import mappings should ignore the position of last mapping if the mappings are pivoted. This did not happen, however, when one of the other mappings was marked as header and there were no explicitly set pivoted mappings. We now take this special case into account. Re spine-tools/Spine-Toolbox#2224
Mappings are not pivoted when only the leaf mapping has position set to header. Re spine-tools/Spine-Toolbox#2224
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 75.33% 75.39% +0.06%
==========================================
Files 76 76
Lines 10921 10921
Branches 2378 2378
==========================================
+ Hits 8227 8234 +7
+ Misses 2253 2246 -7
Partials 441 441
☔ View full report in Codecov by Sentry. |
soininen
deleted the
toolbox_2224_fix_import_mappings_when_pivoted_by_header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in
import_mappings:Fixes spine-tools/Spine-Toolbox#2224
@manuelma FYI: this touches some stuff that may conflict with the entity branch.
Checklist before merging