[acl] Remove Ethertype from L3V6 qualifiers #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <[email protected]>
|
what platform is broken? |
zhenggen-xu
reviewed
Sep 15, 2020
zhenggen-xu
approved these changes
Sep 19, 2020
lguohan
approved these changes
Sep 19, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 19, 2020
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox). Signed-off-by: Danny Allen <[email protected]>
yxieca
pushed a commit
that referenced
this pull request
Oct 5, 2020
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox). Signed-off-by: Danny Allen <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* SAI submodule update - d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451) - 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437) - 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433) Signed-off-by: bingwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
What I did
I removed ethertype from the qset for L3V6 tables.
Why I did it
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox).
How I verified it
Details if related