Skip to content

Commit

Permalink
[acl] Remove Ethertype from L3V6 qualifiers (#1433)
Browse files Browse the repository at this point in the history
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox).

Signed-off-by: Danny Allen <[email protected]>
  • Loading branch information
daall authored and yxieca committed Oct 5, 2020
1 parent 2e542b5 commit 4999565
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion orchagent/aclorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,12 @@ bool AclRuleL3V6::validateAddMatch(string attr_name, string attr_value)
return false;
}

if (attr_name == MATCH_ETHER_TYPE)
{
SWSS_LOG_ERROR("Ethertype match is not supported for table type L3V6");
return false;
}

return AclRule::validateAddMatch(attr_name, attr_value);
}

Expand Down Expand Up @@ -1248,7 +1254,7 @@ bool AclTable::create()
return status == SAI_STATUS_SUCCESS;
}

if (type != ACL_TABLE_MIRRORV6)
if (type != ACL_TABLE_MIRRORV6 && type != ACL_TABLE_L3V6)
{
attr.id = SAI_ACL_TABLE_ATTR_FIELD_ETHER_TYPE;
attr.value.booldata = true;
Expand Down

0 comments on commit 4999565

Please sign in to comment.