Add DHCP Relay #38

mbrar · 2016-10-21T21:56:19Z

-added Dhcp Relay Docker
-added isc-dhcp-server package to ptf docker to avoid manually installing server for testing

qiluo-msft · 2016-10-24T17:42:15Z

dockers/docker-dhcp-relay/isc-dhcp-relay

+
+INTERFACES=""
+
+#-a provides option 82 circuit id information


The comment does not make sense. #Closed

I think Manny is explaining that the -a option enables the relay agent to use DHCP's option82 function.
Manny, I think you need to actually specify OPTIONS="-a", right?

Yes, the -a option enables the use of DHCP Option 82. I left Option 82 off by default but it might make more sense to set OPTIONS="-a"

qiluo-msft · 2016-10-24T17:43:27Z

dockers/docker-dhcp-relay/Dockerfile

+ENV DEBIAN_FRONTEND=noninteractive
+
+RUN apt-get update && apt-get -y install \
+        isc-dhcp-relay


clean up apt in the same 'RUN' command to save disk space. #Closed

qiluo-msft · 2016-10-24T17:44:14Z

dockers/docker-ptf/Dockerfile

@@ -35,6 +35,7 @@ RUN sed --in-place 's/httpredir.debian.org/debian-archive.trafficmanager.net/' /
        python-dev          \
        wget                \
        cmake               \
+	isc-dhcp-server	    \


indentation not aligned.

why install in ptf docker? #Closed

DHCP server is used for DHCP testing. One option was to create a seperate Docker container for the server but after discussion with Pavel and Darren it seems ok to just install isc-dhcp-server in the ptf docker. The client (ptf code) and server run on the same docker container.

I think it is better to remove this package from ptf docker since ptf docker is generic docker for testing purpose, what if some other one want to use ptf docker to test another dhcp server implementation?

It is better to move this into the ansible playbook of the test itself.

In reply to: 84995018 [](ancestors = 84995018)

Okay, that's an easy change. I will install and start dhcp server from playbook instead.

dplore

Leave a comment

dplore · 2016-10-25T17:19:16Z

dockers/docker-dhcp-relay/isc-dhcp-relay

+
+INTERFACES=""
+
+#-a provides option 82 circuit id information


I think Manny is explaining that the -a option enables the relay agent to use DHCP's option82 function.
Manny, I think you need to actually specify OPTIONS="-a", right?

…g option

mbrar

added clean up in dockerfile, fixed indentation, and added option 82 "-a" flag as default for relay config

lguohan · 2016-10-25T21:38:35Z

dockers/docker-dhcp-relay/Dockerfile

+COPY isc-dhcp-relay /etc/default/isc-dhcp-relay
+
+ENTRYPOINT service isc-dhcp-relay start \
+	&& /bin/bash


do we need to start rsyslog in the docker? how do we provide logging functionaility?

addressed in latest iteration, used rsyslog

lguohan

requested changes

qiluo-msft · 2016-10-25T22:13:25Z

dockers/docker-dhcp-relay/Dockerfile

+## Clean up
+RUN apt-get update && apt-get -y install \
+        isc-dhcp-relay &&		 \
+	apt-get clean -y; apt-get autoclean -y; apt-get autoremove -y


Mix tabs with spaces. Several times in this PR. #Closed

qiluo-msft · 2016-10-25T22:14:03Z

dockers/docker-ptf/Dockerfile

@@ -35,6 +35,7 @@ RUN sed --in-place 's/httpredir.debian.org/debian-archive.trafficmanager.net/' /
        python-dev          \
        wget                \
        cmake               \
+	 isc-dhcp-server     \


tab and space mixing #Closed

stcheng · 2016-11-01T22:43:55Z

❓

dplore

LGTM

[rfc4363]: Add key check logic for SAI bridge port objects (#38)

* [device] Update arista driver submodule * Set Arista scd driver config Set ARISTA_SCD_DRIVER_CONFIG config to build and include scd driver to resulting Arista deb packages

improve app/sai/counter db dump performance get bgp neighbor received routes

* [_sonic_yang_ext.py]: Parse multilist in YANG Container. This is needed to support VRF feature in SONiC. Signed-off-by: Praveen Chaudhary [email protected] * [sonic-vlan.yang]: Change Vlan yang models to remove admin-status as mandatory attribute. Signed-off-by: Praveen Chaudhary [email protected] * [_sonic_yang_ext.py]: Minor fix in _sonic_yang_ext.py Signed-off-by: Praveen Chaudhary [email protected]

* src/sonic-telemetry fa8d498...3bd7ca3 (4): > Update gnmi deps (#40) > [testdata] Update SFP keys to align with new standard (#39) > Fixed the parameters for subscribe APIs (#38) > Azure ro mode (#34) * src/sonic-mgmt-common 444aa9a...cc01ce4 (4): > Make gnmi dep version the same as in telemetry repo (#17) > Cleanup translib and cvl go test cases (#13) > Package update and enhancements/fixes in YGOT, and Request Binder (#12) > Translib phase I changes (#11) Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch

…onic-net#38)

1. add parsing for: dom_control_bytes_masks, dom_option_value_masks and dom_module_monitor 2. adjust indent

Signed-off-by: Shu0T1an ChenG <[email protected]>

df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>

df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (#35) Signed-off-by: Abhishek Dosi <[email protected]>

df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>

Signed-off-by: Mykola Faryma <[email protected]>

df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>

…-net#38) 1. wrap the apis that are supported by new platform api in a way that to call npapi first and to call sfputil if the former returns NotImplementError. 2. for the functions that only available in sfputil, a helper module is introduced to replace sfputil.

) It is possible that some ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT doesn't have the attribute SAI_BRIDGE_PORT_ATTR_PORT_ID. We need to exclude it.

f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41) ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39) ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36) c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38) b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37) bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28) 9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33) b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31) 9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)

IP SLA HLD v1

* 3beaadc (HEAD, origin/master, origin/HEAD, master) Improve unit test for gnmi (#38) * a12fcd8 Merge pull request #13 from renukamanavalan/statistics * | 28b2f27 Enable unit test * | 65e3c8f Add log for authentication and add unit test. #12 * | 1b3b838 Merge pull request #8 from ganglyu/fix_pipeline

This reverts commit 617559c.

…tches (sonic-net#38) Signed-off-by: Qi Luo <[email protected]>

[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205

Manjot Brar added 6 commits October 20, 2016 19:06

added dhcp relay docker file, added isc-dhcp-relay config file

cdf6370

added dhcp server package to ptf

52d9847

changed indentation

f993736

fixed indent

fa22332

space change

9855425

fixed space

ff30453

qiluo-msft requested changes Oct 24, 2016

View reviewed changes

dplore suggested changes Oct 25, 2016

View reviewed changes

Manjot Brar added 4 commits October 25, 2016 14:19

added clean in relay docker, fixed indentation, and fixed relay confi…

defefb4

…g option

fixing indentation...

89ac3bd

fixing indentation again

43af986

fixing indentation once again

55730ba

mbrar commented Oct 25, 2016

View reviewed changes

lguohan reviewed Oct 25, 2016

View reviewed changes

lguohan requested changes Oct 25, 2016

View reviewed changes

qiluo-msft requested changes Oct 25, 2016

View reviewed changes

changed tabs/space indentation differences

0d37b2f

stcheng changed the title ~~Manny Dhcp Relay~~ Add DHCP Relay Oct 26, 2016

Manjot Brar added 2 commits November 8, 2016 09:49

added rsyslog

6bc5703

removed isc-dhcp-server from ptf

5a88ed1

lguohan force-pushed the master branch 2 times, most recently from b36a160 to dc84c41 Compare November 15, 2016 14:17

qiluo-msft approved these changes Nov 15, 2016

View reviewed changes

dplore approved these changes Nov 15, 2016

View reviewed changes

lguohan approved these changes Nov 21, 2016

View reviewed changes

stcheng merged commit 691b787 into master Nov 24, 2016

stcheng deleted the manny_dhcp_relay branch November 28, 2016 20:23

stcheng mentioned this pull request Sep 26, 2017

[snmp]: Update sonic-snmpaget submodule #986

Merged

stcheng pushed a commit that referenced this pull request Sep 26, 2017

[snmp]: Update sonic-snmpagent submodule (#986)

cce2a36

[rfc4363]: Add key check logic for SAI bridge port objects (#38)

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

archive coredump files in the generate_dump (sonic-net#38)

11db861

improve app/sai/counter db dump performance get bgp neighbor received routes

jleveque added DHCP Relay Enhancement ➕ labels Jul 9, 2020

jleveque mentioned this pull request Jul 17, 2020

[sonic-telemetry][sonic-mgmt-common] Update submodules #4986

Merged

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

unify syncd init script on different platforms and add s6100 support (s…

293beb6

…onic-net#38)

vdahiya12 pushed a commit to vdahiya12/sonic-buildimage that referenced this pull request Oct 2, 2020

[sff8436] support "Control Bytes" and "Options" (sonic-net#38)

f19c061

1. add parsing for: dom_control_bytes_masks, dom_option_value_masks and dom_module_monitor 2. adjust indent

xumia referenced this pull request in xumia/sonic-buildimage-1 Feb 16, 2021

[jenkins]: Move script out of Jenkinsfile for re-use purpose (#38)

f3a13a4

Signed-off-by: Shu0T1an ChenG <[email protected]>

SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Jun 16, 2021

[port_util] Do not use Enum, for python2 compatibility (sonic-net#38)

7ce52d8

Signed-off-by: Mykola Faryma <[email protected]>

zjswhhh mentioned this pull request Mar 17, 2022

[sonic-linkmgrd][master] submodule update #10271

Merged

6 tasks

sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022

Merge pull request sonic-net#38 from hasan-brcm/master

5533681

IP SLA HLD v1

renukamanavalan mentioned this pull request Sep 4, 2022

submodule update: sonic-gnmi #11961

Closed

7 tasks

zbud-msft added a commit to zbud-msft/sonic-buildimage that referenced this pull request Oct 6, 2022

Revert "Proposed yang model changes (sonic-net#35)" (sonic-net#38)

5bd7d95

This reverts commit 617559c.

shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023

Upgrade kernel to 3.16.51-3+deb8u1 based on latest debian security pa…

02b5c0b

…tches (sonic-net#38) Signed-off-by: Qi Luo <[email protected]>

mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024

Merge pull request sonic-net#38 from mssonicbld/sonicbld/202205-merge

568064d

[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DHCP Relay #38

Add DHCP Relay #38

mbrar commented Oct 21, 2016

qiluo-msft Oct 24, 2016 •

edited

Loading

dplore Oct 25, 2016

mbrar Oct 25, 2016 •

edited

Loading

qiluo-msft Oct 24, 2016 •

edited

Loading

mbrar Oct 25, 2016

qiluo-msft Oct 24, 2016 •

edited

Loading

mbrar Oct 25, 2016

lguohan Oct 25, 2016

mbrar Oct 25, 2016

dplore left a comment

dplore Oct 25, 2016

mbrar left a comment

lguohan Oct 25, 2016

mbrar Nov 8, 2016

lguohan left a comment

qiluo-msft Oct 25, 2016 •

edited

Loading

qiluo-msft Oct 25, 2016 •

edited

Loading

stcheng commented Nov 1, 2016

dplore left a comment

Add DHCP Relay #38

Add DHCP Relay #38

Conversation

mbrar commented Oct 21, 2016

qiluo-msft Oct 24, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbrar Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Oct 24, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiluo-msft Oct 24, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dplore left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbrar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

qiluo-msft Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

stcheng commented Nov 1, 2016

dplore left a comment

Choose a reason for hiding this comment

qiluo-msft Oct 24, 2016 •

edited

Loading

mbrar Oct 25, 2016 •

edited

Loading

qiluo-msft Oct 24, 2016 •

edited

Loading

qiluo-msft Oct 24, 2016 •

edited

Loading

qiluo-msft Oct 25, 2016 •

edited

Loading

qiluo-msft Oct 25, 2016 •

edited

Loading