Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic fw upgrade for mlnx platform (#18) #31

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Automatic fw upgrade for mlnx platform (#18) #31

merged 2 commits into from
Oct 18, 2016

Conversation

marian-pritsak
Copy link
Collaborator

Implement script for firmware upgrade to required version
Add firmware binary and script to ops-syncd-mlnx container
Add pciutils and usbutils to sonic-generic.bin

Signed-off-by: marian-pritsak [email protected]

Implement script for firmware upgrade to required version
Add firmware binary and script to ops-syncd-mlnx container
Add pciutils and usbutils to sonic-generic.bin

Signed-off-by: marian-pritsak <[email protected]>
@qiluo-msft
Copy link
Collaborator

Why including firmware upgrade into syncd docker? Is it one-time thing?

@@ -183,7 +183,9 @@ sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install \
bsdmainutils \
ca-certificates \
i2c-tools \
efibootmgr
efibootmgr \
usbutils \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which component requires this usbutils?

Copy link
Collaborator Author

@marian-pritsak marian-pritsak Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mst utility uses usbutils and pciutils to talk to detect ASIC device

@@ -8,6 +8,10 @@ function clean_up {

trap clean_up SIGTERM SIGKILL

# fw-upgrade will exit if firmware was actually upgraded or if some error
# occures
. mlnx-fw-upgrade.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after upgrading the fw, do we need to restart the sxd kernel driver?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to restart sxd kernel in order to run newly burned firmware

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it is needed to add restart sxdkernel driver logic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct
If firmware is actually updated, mlnx-fw-upgrade.sh will exit, causing syncd service to restart

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.

BTW, syncd service to restart == restart sxdkernel driver?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiluo-msft yes. restart syncd service will restart sxdkernel driver

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.

There is a comment in start.sh line 11 and mlnx-fw-upgrade.sh line 51 regarding restart logic. Anything else needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thanks!

@marian-pritsak
Copy link
Collaborator Author

As MLNX SDK is shipped with syncd docker, firmware upgrade utility is also going to be a part of it, so that in case of rolling out a new version of SDK, a compatible version of firmware will be installed.

During syncd start firmware version is verified to be compatible with SDK shipped with current syncd, and if not - upgrade procedure is initiated. Its a one time action, which happens only when new SDK is available in syncd.

@@ -8,6 +8,10 @@ function clean_up {

trap clean_up SIGTERM SIGKILL

# fw-upgrade will exit if firmware was actually upgraded or if some error
# occures
. mlnx-fw-upgrade.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.

BTW, syncd service to restart == restart sxdkernel driver?

if [[ ${required_fw_version} == ${fw_version} ]]; then
echo "Mellanox firmware is up to date."
else
echo "Mellanox firmware required version is ${required_fw_version}. Upgrading..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading is also possible here. Is it safe to downgrade? Maybe you can refine the message.

It is possible to do both upgrade and downgrade
Change "Upgrading" to "Installing compatible version"
@qiluo-msft qiluo-msft merged this pull request into sonic-net:master Oct 18, 2016
stcheng pushed a commit that referenced this pull request Oct 18, 2016
* Automatic fw upgrade for mlnx platform

Implement script for firmware upgrade to required version
Add firmware binary and script to ops-syncd-mlnx container
Add pciutils and usbutils to sonic-generic.bin

* Update firmware installation message

It is possible to do both upgrade and downgrade
Change "Upgrading" to "Installing compatible version"

Signed-off-by: marian-pritsak <[email protected]>
stcheng pushed a commit that referenced this pull request Mar 22, 2017
* Automatic fw upgrade for mlnx platform

Implement script for firmware upgrade to required version
Add firmware binary and script to ops-syncd-mlnx container
Add pciutils and usbutils to sonic-generic.bin

* Update firmware installation message

It is possible to do both upgrade and downgrade
Change "Upgrading" to "Installing compatible version"

Signed-off-by: marian-pritsak <[email protected]>
lguohan pushed a commit that referenced this pull request Oct 24, 2018
* Move bfn asic drivers out of platform package (#30)

* Move bfn asic drivers out of platform package

* Change debian pkg name for bfn modules

* Change license file

* Fix build breakage due to dependency issue

* Minor changes to debian bld files (#31)
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
vasant17 pushed a commit to vasant17/sonic-buildimage that referenced this pull request Jan 23, 2020
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
dflynn-Nokia added a commit to dflynn-Nokia/sonic-buildimage that referenced this pull request Dec 4, 2020
This update brings in the following commits.

86c1108 Enable arm architecture to build in addition to amd64 (sonic-net#37)
4acb2c3 fix bugs and enhance Transformer (sonic-net#35)
49e5a22 ygot related enhancements and fixes (sonic-net#34)
51224de Fix ietf yang search path for cvl schema builds (sonic-net#32)
3c6cdb3 CVL Changes sonic-net#8: 'must' and 'when' expression evaluation (sonic-net#31)
dabf231 CVL Changes sonic-net#7: 'leafref' evaluation (sonic-net#28)
6f9535f CVL Changes sonic-net#6: Customized Xpath Engine integration (sonic-net#27)
5e2466b DB-Layer fixes/enhancements (sonic-net#26)
9a27302 CVL Changes sonic-net#4: Implementation of new CVL APIs (sonic-net#22)
dbf1093 Translib support for authorization, yang versioning and Delete flag (sonic-net#21)
80f369e CVL Changes sonic-net#5: YParser enhancement (sonic-net#23)
904ce18 CVL Changes sonic-net#3: Multi-db instance support (sonic-net#20)
9d24a34 CVL Changes sonic-net#2:  YValidator infra changes for evaluating xpath expression (sonic-net#19)
f3fc40f CVL Changes sonic-net#1: Initial CVL code reorganization and common infra changes (sonic-net#18)
4922601 Bulk and RPC API support in translib (sonic-net#16)
1d730df RFC7895 yang module library implementation (sonic-net#15)
lguohan pushed a commit that referenced this pull request Dec 8, 2020
This update brings in the following commits.

86c1108 Enable arm architecture to build in addition to amd64 (#37)
4acb2c3 fix bugs and enhance Transformer (#35)
49e5a22 ygot related enhancements and fixes (#34)
51224de Fix ietf yang search path for cvl schema builds (#32)
3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31)
dabf231 CVL Changes #7: 'leafref' evaluation (#28)
6f9535f CVL Changes #6: Customized Xpath Engine integration (#27)
5e2466b DB-Layer fixes/enhancements (#26)
9a27302 CVL Changes #4: Implementation of new CVL APIs (#22)
dbf1093 Translib support for authorization, yang versioning and Delete flag (#21)
80f369e CVL Changes #5: YParser enhancement (#23)
904ce18 CVL Changes #3: Multi-db instance support (#20)
9d24a34 CVL Changes #2:  YValidator infra changes for evaluating xpath expression (#19)
f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18)
4922601 Bulk and RPC API support in translib (#16)
1d730df RFC7895 yang module library implementation (#15)
xumia referenced this pull request in xumia/sonic-buildimage-1 Feb 16, 2021
SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Jun 16, 2021
SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Mar 16, 2022
* Exclude non front panel interfaces from nexthop

* Fix non front panel interface matching

* Fix wrong operators
lguohan pushed a commit that referenced this pull request Mar 18, 2022
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41)
ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39)
ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36)
c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38)
b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37)
bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28)
9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md
c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33)
b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31)
9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
prgeor pushed a commit that referenced this pull request Sep 29, 2022
* [BFN] Canceling PSU platform API calls on SIGTERM

Signed-off-by: Andriy Kokhan <[email protected]>

* [BFN] Fixed SONiC fwutil exec time (#31)

Signed-off-by: Taras Keryk <[email protected]>

Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Taras Keryk <[email protected]>
Co-authored-by: Taras Keryk <[email protected]>
zbud-msft added a commit to zbud-msft/sonic-buildimage that referenced this pull request Oct 6, 2022
yxieca pushed a commit that referenced this pull request Feb 6, 2023
Why I did it
Advance sonic-dhcp-relay submodule head on 202012 branch

How I did it
Added the following commits:
a4b15d8 jcaiMR Thu Dec 29 14:18:28 2022 +0800 fix relay-reply dhcpv6 packet counter issue (#29)
677543f jcaiMR Sat Dec 17 00:24:32 2022 +0800 fix handleSwssNotification crash in dhcp6relay (#28)
ed86546 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (#27)
5ec1f5b Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (#22)
063d41b jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (#25)
d4a51f6 kellyyeh Tue Jan 31 18:09:08 2023 -0800 Add unittest infrastructure (#5) (#31)

How to verify it
Ran full dhcpv6 test suite on lab device
Gokulnath-Raja pushed a commit to Gokulnath-Raja/sonic-buildimage-work that referenced this pull request May 22, 2023
…ic-net#31)

Adding support for evaluating 'must' and 'when' expression based on customized xpath engine.
shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023
speed up kernel compile.

- DO_DOCS=False do not skip generate document package on 4.19, use DEB_BUILD_PROFILES=nodoc instead.
- use arch_amd64_none_amd64 to build the amd64 kernel package, avoid generating cloud-amd64 package.

As a result, jenkins pipeline linux-kernel-buster-build-pr job sonic-net#31 takes 1h 6min, compare to sonic-net#30 takes 1h 24min.

Co-authored-by: taocy <[email protected]>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…ic-utilities

[submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically
* c4dcb32 - (HEAD -> 202205, origin/202205) Merge pull request sonic-net#31 from mssonicbld/sonicbld/202205-merge (3 days ago) [mssonicbld]
* bb5123d - Merge branch '202205' of https://github.com/sonic-net/sonic-utilities into 202205 (3 days ago) [Sonic Automation]
* ff8a064 - [202205][acl-loader] Identity ICMP v4/v6 based on IP_PROTOCOL for custom ACL table types (sonic-net#3003) (3 days ago) [Zhijian Li]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants