-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show error on Editor composer textarea #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I have textarea with error and switch to markdown preview and back error state disappears.
Fixed. Also added validation to the user space statement |
Can we show a different limit on space using Turbo? It should be 40k for Turbo, also for normal spaces I believe the limit should be 10k |
Yes, but this will come from a different PR #524 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Summary
Laying the groundworks for #517
The current proposal creation form does not validate the body, it just set a hard limit on the body textarea.
In addition, the composer editor textarea is not styled exactly like the rest of the textarea, preventing using the same css to style the errors.
This PR will:
Test
The PREVIEW markdown tab default height has also been adjusted to match the textarea height by default