Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: missing title and body max length on proposal #517

Closed
2 tasks done
wa0x6e opened this issue Jul 22, 2024 · 2 comments · Fixed by #524
Closed
2 tasks done

bug: missing title and body max length on proposal #517

wa0x6e opened this issue Jul 22, 2024 · 2 comments · Fixed by #524
Assignees
Labels
bug Something isn't working

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 22, 2024

On the proposal, there's no max limit set on the length of the title, body and discussion field.

This will:

  • fail on offchain, as sequencer will throw an error
  • process and submit the tx as valid on onchain, but will fail to index on checkpoint

Solution: we should set a common max limit (onchain/offchain) on all fields

Tasks

Preview Give feedback
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 23, 2024

This also need to take into account turbo spaces

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 24, 2024

I think this fix will also enable #83

@aurelianoB aurelianoB added the bug Something isn't working label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants