Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factor loop-match pattern out of AssertAsync method impls #64

Merged
merged 1 commit into from
Nov 7, 2022
Merged

factor loop-match pattern out of AssertAsync method impls #64

merged 1 commit into from
Nov 7, 2022

Conversation

fogti
Copy link
Member

@fogti fogti commented Nov 6, 2022

Noticed this during the review of #62. I'm open for bikeshedding on the assert_async_antipoll name.

@fogti fogti force-pushed the assert-async-refac branch from 4826453 to 28e0d14 Compare November 6, 2022 22:30
notgull
notgull approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

assert_async_antipoll is an odd name, in my opinion. I think it would be better if it was named wrap_io and was an associated method on AssertAsync.

@fogti fogti force-pushed the assert-async-refac branch from 28e0d14 to d21bfc5 Compare November 6, 2022 23:26
@fogti
Copy link
Member Author

fogti commented Nov 6, 2022

I didn't want to make it an associated method because it's completely independent from the type parameter <T>

@fogti
Copy link
Member Author

fogti commented Nov 6, 2022

I renamed it to assert_async_wrapio.

notgull
notgull approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new name better.

@fogti fogti merged commit 4c03e0d into master Nov 7, 2022
@fogti fogti deleted the assert-async-refac branch November 7, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fogti @notgull