Add a combinator for temporarily using an AsyncRead/AsyncWrite as Read/Write #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy error is unrelated to this PR, see #63 |
fogti
requested changes
Nov 6, 2022
notgull
force-pushed
the
sync-conversion
branch
from
20350b4 to
93abc09
Compare
fogti
reviewed
Nov 7, 2022
Co-authored-by: Alain Zscheile <[email protected]>
fogti
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During smol-rs/async-rustls#9, @zseri pointed out that we frequently use a type that just converts an
AsyncReadto aReadtemporarily so that it can be used inrustls, which only takes aRead. This pattern is not unique toasync-rustls, since I've also seen this used intokio-tungstenite, following a similar pattern.In order to deduplicate instances of this pattern throughout the ecosystem, this PR implements this pattern as a type in the
iomodule.