Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic when platformBindings.connect throws an exception #795

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Don't panic when platformBindings.connect throws an exception #795

merged 4 commits into from
Jun 22, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 22, 2023

Fix #794

@tomaka tomaka mentioned this pull request Jun 22, 2023
Closed
@tomaka tomaka added this pull request to the merge queue Jun 22, 2023
Merged via the queue into smol-dot:main with commit 34d6a72 Jun 22, 2023
@tomaka tomaka deleted the no-panic-connect branch June 22, 2023 16:40
tomaka added a commit to tomaka/smoldot that referenced this pull request Jun 23, 2023
@tomaka
Revert "Don't panic when platformBindings.connect throws an exception (…
7234619 
…smol-dot#795)"

This reverts commit 34d6a72.
@tomaka tomaka mentioned this pull request Jun 23, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 23, 2023
@tomaka
Fix #794 differently (#800)
3b30af6 
* Revert "Don't panic when platformBindings.connect throws an exception (#795)"

This reverts commit 34d6a72.

* Fix the problem differently

* Must not throw

* PR link

* Be more passive aggressive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smoldot gets panicked on HTTPS
1 participant
@tomaka