Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoldot gets panicked on HTTPS #794

Closed
Douglasacost opened this issue Jun 22, 2023 · 2 comments · Fixed by #795
Closed

Smoldot gets panicked on HTTPS #794

Douglasacost opened this issue Jun 22, 2023 · 2 comments · Fixed by #795

Comments

@Douglasacost
Copy link

Locally over http seems to be working fine, but somehow on https always fail with the following error

client.js:89 Smoldot has panicked while executing task `connection-12D3KooW9tfcevBR9DjD1JznXY7TenxVoDvtuVKndjgWNizjGUCs-/dns4/node-6975196240558477312-0.p2p.onfinality.io/tcp/25394/ws`. This is a bug in smoldot. Please open an issue at https://github.com/smol-dot/smoldot/issues with the following message: panicked at 'called `Result::unwrap()` on an `Err` value: "WouldBlock"', wasm-node/rust/src/platform.rs:722:37

screenshot:
image

Smoldot v1.0.9

@tomaka
Copy link
Contributor

tomaka commented Jun 22, 2023

Thanks for the report!

Note that you can by passing the issue by passing forbidNonLocalWs: true when calling start.
#795 fixes the panic, but the error will still happen afterwards, as it is a browser restriction, and the only way to avoid this error is pass forbidNonLocalWs: true, so you probably want to do that anyway.

@Douglasacost
Copy link
Author

thanks @tomaka ❤️

@Douglasacost Douglasacost changed the title Smodlot gets panicked on HTTPS Smoldot gets panicked on HTTPS Jun 23, 2023
github-merge-queue bot pushed a commit that referenced this issue Jun 23, 2023
* Revert "Don't panic when platformBindings.connect throws an exception (#795)"

This reverts commit 34d6a72.

* Fix the problem differently

* Must not throw

* PR link

* Be more passive aggressive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants