-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the networking abstraction of the Platform trait #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiggy diff reportDifference in .wasm size before and after this pull request.
|
While updating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Platform
trait exposed bylight-base
in order to improve the abstraction over "streams" (i.e. TCP or WebSocket connections, or WebRTC substreams).It now allows closing the sending side, and no longer allows an unlimited amount of outgoing data.
As part of this PR, most of the
AsyncStdTcpWebSocket
has been rewritten in a clean way. There's no cursed background task that sends and receives messages from the front or whatnot. Instead, things are now "flat" and the socket is polled directly in the future manipulated by the networking task.Finishing this consists in updating the wasm-node implementation of
Platform
as well.