This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Allow integrated relay chain light client #2270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
A0-please_review
Pull request needs code review.
B1-note_worthy
Changes should be noted in the release notes
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Mar 3, 2023
skunert
added
the
C1-low
PR touches the given topic and has a low impact on builders.
label
Mar 3, 2023
dmitry-markin
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as I understood the underlying logic from the code of PR.
Co-authored-by: Dmitry Markin <[email protected]>
michalkucharczyk
approved these changes
Jun 19, 2023
davxy
approved these changes
Jun 21, 2023
LGTM mostly nitpicks |
Co-authored-by: Davide Galassi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T0-node
This PR/Issue is related to the topic “node”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added a command line flag
--relay-chain-rpc-client
to enable experimental support for an embedded light client.This leaves us with three execution modes for the relay chain:
Implementation Overview
jsonrpsee
library and let it handle subscription and request managementRemaining issues
This issue is impacting us, I will take a look at what needs to be done on the substrate side: