Remove MalformedJsonRpcError
#1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1098
Removing this makes smoldot "more conforming" to the specification. It removes possible confusion due to the fact that smoldot didn't do exactly what the JSON-RPC specification says should happen.
It also makes it easier in general to plug an actual TCP/IP JSON-RPC server on top of a light client if needed, without having to understand the JSON-RPC specification.
The drawback of this PR is that it removes feedback about which request exactly has an issue. However this is very much a "never supposed to happen" problem, and this feedback is pretty useless.