Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON-RPC parse error result on server entry point #1098

Closed
tomaka opened this issue Sep 4, 2023 · 1 comment · Fixed by #1116
Closed

Remove JSON-RPC parse error result on server entry point #1098

tomaka opened this issue Sep 4, 2023 · 1 comment · Fixed by #1116

Comments

@tomaka
Copy link
Contributor

tomaka commented Sep 4, 2023

The JSON-RPC spec mentions that

If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null.

Given that there exists a mechanism for that situation, I think that it is more appropriate to use that mechanism to notify the JSON-RPC client of a parsing error rather than return a Result which is difficult to handle.

@tomaka
Copy link
Contributor Author

tomaka commented Sep 6, 2023

The first step is to change the mechanism where large requests return an error. Instead, they should generate an erroneous JSON-RPC response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant