Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use ip-address-manager to allocate IPs #28

Merged

Conversation

scuzhanglei
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #28 (307f657) into main (7aa253b) will decrease coverage by 8.48%.
The diff coverage is 10.86%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   48.17%   39.68%   -8.49%     
==========================================
  Files           4        3       -1     
  Lines         465      451      -14     
==========================================
- Hits          224      179      -45     
- Misses        209      241      +32     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
controllers/virtinkmachine_controller.go 35.16% <10.86%> (-5.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fengye87
fengye87 previously approved these changes Nov 24, 2022
@scuzhanglei scuzhanglei force-pushed the integrate-with-ip-address-manager branch from fcfed7d to 307f657 Compare November 24, 2022 02:27
@scuzhanglei
Copy link
Contributor Author

@fengye87 just rebased, please review again.

@scuzhanglei scuzhanglei merged commit f181326 into smartxworks:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants