Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid allocating repeated IP to machines #25

Conversation

scuzhanglei
Copy link
Contributor

No description provided.

@scuzhanglei scuzhanglei force-pushed the fix-machine-address-allocate-race branch from 8796ef5 to b762c97 Compare November 8, 2022 11:05
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #25 (40af3ae) into main (37ae04d) will decrease coverage by 1.71%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   52.92%   51.20%   -1.72%     
==========================================
  Files           3        3              
  Lines         427      496      +69     
==========================================
+ Hits          226      254      +28     
- Misses        170      200      +30     
- Partials       31       42      +11     
Impacted Files Coverage Δ
controllers/virtinkcluster_controller.go 41.63% <26.31%> (-10.89%) ⬇️
controllers/virtinkmachine_controller.go 53.27% <42.85%> (+7.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scuzhanglei scuzhanglei marked this pull request as draft November 14, 2022 03:48
@scuzhanglei scuzhanglei force-pushed the fix-machine-address-allocate-race branch from b762c97 to 27777c8 Compare November 14, 2022 10:09
@scuzhanglei scuzhanglei force-pushed the fix-machine-address-allocate-race branch from 27777c8 to 40af3ae Compare November 14, 2022 10:25
@scuzhanglei scuzhanglei marked this pull request as ready for review November 14, 2022 10:26
Copy link
Contributor

@fengye87 fengye87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if we should DIY IP allocation in this project. Could we pend this PR first and try the metal3's ip address manager first?

@scuzhanglei
Copy link
Contributor Author

I'm still not sure if we should DIY IP allocation in this project. Could we pend this PR first and try the metal3's ip address manager first?

okay, I will submit another PR to compare.

@scuzhanglei
Copy link
Contributor Author

new PR #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants