[BT-151] AppHeader #42
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
|
|
||
| import React, { | ||
| Component, | ||
| PropTypes, | ||
| } from 'react'; | ||
|
|
||
| import AccountPicture from './AccountPicture.jsx'; | ||
|
|
||
| export default class AccountNav extends Component { | ||
|
|
||
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
|
There was a problem hiding this comment. I think we should move this into In short, I don't think it hurts anything to move this into the props, and it gives us the option of reacting to or acting upon this state globally. |
||
| isOpen: false, | ||
| }; | ||
| } | ||
|
|
||
| onClick() { | ||
| this.setState({ | ||
| isOpen: !this.state.isOpen, | ||
| }); | ||
| } | ||
|
|
||
| render() { | ||
| const dropdownClass = !this.state.isOpen ? | ||
|
There was a problem hiding this comment. Let's use const dropdownClass = classNames('accountDropdownArrow', {
'is-account-dropdown-arrow-open': this.props.isOpen,
}); |
||
| 'dropdownArrow' : | ||
| 'dropdownArrow--reverse'; | ||
|
|
||
| return ( | ||
| <a | ||
| className="accountNav" | ||
| onClick={this.onClick.bind(this)} | ||
| > | ||
| <AccountPicture | ||
| url={this.props.pictureUrl} | ||
| title={this.props.email} | ||
| /> | ||
| <span className="accountNav__email"> | ||
| {this.props.email} | ||
| </span> | ||
| <span className={dropdownClass}></span> | ||
| </a> | ||
| ); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| AccountNav.propTypes = { | ||
| email: PropTypes.string.isRequired, | ||
| pictureUrl: AccountPicture.propTypes.url, | ||
| }; | ||
|
|
||
| export default AccountNav; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
|
|
||
| import React, { | ||
| Component, | ||
| PropTypes, | ||
| } from 'react'; | ||
|
|
||
| export default class AccountPicture extends Component { | ||
|
There was a problem hiding this comment. I think this could be made into a pure functional component. |
||
|
|
||
| constructor(props) { | ||
| super(props); | ||
| } | ||
|
|
||
| render() { | ||
| const picture = this.props.url ? <img src={this.props.url} /> : null; | ||
|
|
||
| return ( | ||
| <span className="icon glyphicons-user accountPicture"> | ||
| {picture} | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| AccountPicture.propTypes = { | ||
| url: PropTypes.string, | ||
| title: PropTypes.string, | ||
| }; | ||
|
|
||
| export default AccountPicture; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be made into a pure functional component. It will make the code shorter and reduce memory usage (a miniscule amount). Unless we anticipate needing to optimize this component with lifecycle hooks, I think it would be good to make it a pure functional component.