[BT-151] AppHeader #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icture example. Added prop to Example component to make background dark
…ow anchor tags and router's link components can be used for AppNav
…extra brackets in calculaing value in styles
| .exampleContainer--dark { | ||
| background: #aaaaaa; | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice! I just played around with this a bit and I'd like to suggest these styles for improved contrast between the background and text color:
.exampleContainer {
// Other styles...
background: white;
.examplePageTitle,
.examplePageSubTitle,
.examplePageText {
color: #5e6162;
}
}
.exampleContainer--dark {
background: #5e6162;
.examplePageTitle,
.examplePageSubTitle,
.examplePageText {
color: white;
}
}
|
This is great! The SCSS follows the BEM format really well. The interfaces for the components are also really nice. I had a lot of comments but they're all pretty simple little things. Nice work. |
…re/BT-151-app-header
…styled dark example. Isolated prototype's dropdownArrow class. Renamed vars and style classes
|
@cjcenizal Thanks for great tips! |
| const picture = props.url ? <img src={props.url} /> : null; | ||
|
|
||
| return ( | ||
| <span className="icon glyphicons-user accountPicture"> |
There was a problem hiding this comment.
Looks like some there's some weird indentation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these things can be maybe be further improved, I'd like to hear your thoughts, if anything come to mind.