Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variables on expiring-todo-comments #399

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Rename variables on expiring-todo-comments #399

merged 1 commit into from
Sep 27, 2019

Conversation

lubien
Copy link
Contributor

@lubien lubien commented Sep 27, 2019 •
edited
Loading

@lubien
Copy link
Contributor Author

lubien commented Sep 27, 2019

There are other pkg* variables. Would it be ok if I update them to package* too?

@lubien lubien mentioned this pull request Sep 27, 2019
Merged
@fisker
Copy link
Collaborator

fisker commented Sep 27, 2019 •
edited
Loading

There are other pkg* variables. Would it be ok if I update them to package* too?

we can do this later, #387 will fix them. thank you

@fisker fisker merged commit c3326d2 into sindresorhus:master Sep 27, 2019
@lubien lubien deleted the issue-394 branch September 27, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubien @fisker