Handle lack of package.json in expiring-todo-comments rule
#397
Conversation
sindresorhus
changed the title
expiring-todo-comments rule
| @@ -17,7 +17,8 @@ const MESSAGE_ID_ENGINE_MATCHES = 'engineMatches'; | |||
| const MESSAGE_ID_REMOVE_WHITESPACES = 'removeWhitespaces'; | |||
| const MESSAGE_ID_MISSING_AT_SYMBOL = 'missingAtSymbol'; | |||
|
|
|||
| const pkg = readPkgUp.sync().package; | |||
| const hasPackage = readPkgUp.sync(); | |||
| const pkg = hasPackage ? hasPackage.package : {}; | |||
There was a problem hiding this comment.
This two line seems weird.
There was a problem hiding this comment.
first thinking
const {package: pkg = {}} = readPkgUp.sync() || {};
const hasPackage = ??? // can't detectnext might better, but extra line
const result= readPkgUp.sync();
const hasPackage = Boolean(result)
const pkg = hasPackage ? result.package : {};or maybe this one
const {
package: pkg = {},
hasPackage = true
} = readPkgUp.sync() || {hasPackage: false}@lubien what do you think
There was a problem hiding this comment.
I agree. I just needed to get this out.
Should probably have been:
const packageResult = readPkgUp.sync();
const hasPackage = Boolean(packageResult);
const packageJson = hasPackage ? packageResult.package : {};There was a problem hiding this comment.
Did we comment at the same time? LOL
what do you think my last code
There was a problem hiding this comment.
Hehe. Seems so. I didn't see your comment until now. Let's go with mine, which is your second one, just with more verbose naming.
There was a problem hiding this comment.
/cc @lubien Could you please send another PR to apply this?
There was a problem hiding this comment.
Sure! But I need a few hours before I can do this if it's not an issue.
| 'fixme', | ||
| 'xxx' | ||
| ], | ||
| terms: ['todo', 'fixme', 'xxx'], |
There was a problem hiding this comment.
In the future, don't do unrelated changes.
There was a problem hiding this comment.
Oh. Might have been the linter but might bad for leaving it, sorry. Won't happen again.
@garyking came with this scenario of a packageless project. For this my choice would be not to allow package related triggers to work at least until a proper package.json file is set up.
Even tho the original issue says eslint 5, this happens also in version 6.
Fixes #394