Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While working on #267 noticed this, but didn't want to bake into it. #268

Merged
merged 2 commits into from
Dec 9, 2021
Merged

While working on #267 noticed this, but didn't want to bake into it. #268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
528f36f
While working on #267 noticed this, but didn't want to bake into it.
vaikas Dec 8, 2021
2c3cca6
Forgot one change, thanks @mattmoor :)
vaikas Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions .github/workflows/verify-k8s.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,36 +189,27 @@ jobs:
automountServiceAccountToken: false
containers:
- name: check-oidc
# This is a version of the cosign image published from CI with https://github.com/sigstore/cosign/pull/955
# TODO(mattmoor): Switch this to a release build after 1.3
image: gcr.io/projectsigstore/cosign/ci/cosign:46e274094551d5b29bd89eaa6499c0f39e60db2f
command: [/busybox/sh, -c]
args:
- |
/ko-app/cosign sign \
`# Target our cluster's Fulcio` \
--fulcio-url http://fulcio-server.fulcio-dev.svc \
`# Pass in the KinD OIDC token` \
--identity-token \$(cat /var/run/kind-oidc/token) \
`# Skip verification of the SCT since we've disabled that above.` \
--insecure-skip-verify=true \
`# Skip upload because we can't avoid Rekor on that path.` \
--upload=false \
${DIGEST}
image: gcr.io/projectsigstore/cosign:v1.4.0
args: [
"sign",
"--fulcio-url=http://fulcio-server.fulcio-dev.svc",
"--insecure-skip-verify=true",
"--upload=false",
"${DIGEST}",
]

env:
- name: COSIGN_EXPERIMENTAL
value: "true"
volumeMounts:
- name: oidc-info
mountPath: /var/run/kind-oidc

mountPath: /var/run/sigstore/cosign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to change path: below to oidc-token

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://chainguard.dev/posts/2021-11-03-zero-friction-keyless-signing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, only forgot one thing to change :) #winning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up my crap! 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still a very unevenly in your favor 🧹

volumes:
- name: oidc-info
projected:
sources:
- serviceAccountToken:
path: token
path: oidc-token
expirationSeconds: 600 # Use as short-lived as possible.
audience: sigstore
EOF
Expand Down