Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While working on #267 noticed this, but didn't want to bake into it. #268

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Dec 8, 2021

Signed-off-by: Ville Aikas [email protected]

Summary

Use the released version of cosign as per todo.

Ticket Link

Fixes

Release Note



env:
- name: COSIGN_EXPERIMENTAL
value: "true"
volumeMounts:
- name: oidc-info
mountPath: /var/run/kind-oidc

mountPath: /var/run/sigstore/cosign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to change path: below to oidc-token

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, only forgot one thing to change :) #winning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up my crap! 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still a very unevenly in your favor 🧹

@mattmoor mattmoor merged commit 6c2a20b into sigstore:main Dec 9, 2021
@vaikas vaikas deleted the use-cosign-1.4 branch December 9, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants