This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Ability to extend and configure desired sink to report lag metrics, adding support to push lag metrics into InfluxDB as well. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt to push lag metrics into InfluxDB as well. Note: This retains currently supported Prometheus as the default sink, if it's not configured.
|
Hi @hariprasad-k, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Fixed #129 |
|
Thanks for the PR @hariprasad-k. I recently merged in #114 which introduced Graphite support. It also created an abstraction for different sinks. If you rebase maybe we can discuss adding more, like influxdb. |
|
Feel free to reopen this PR if you're interested in continuing the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This retains currently supported Prometheus as the default sink, if it's not configured.