Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3031 on branch 1.10.x (Extend benchmarks from basic tutorial) #3056

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #3031: Extend benchmarks from basic tutorial

@lumberbot-app lumberbot-app bot added this to the 1.10.2 milestone May 14, 2024
@flying-sheep flying-sheep enabled auto-merge (squash) May 14, 2024 09:47
Copy link

scverse-benchmark bot commented May 14, 2024

Benchmark changes

Change Before [19a0bb8] After [0e14441] Ratio Benchmark (Parameter)
- 1.32G 1.13G 0.85 preprocessing_counts.peakmem_scrublet('pbmc3k')
- 473M 406M 0.86 preprocessing_counts.peakmem_scrublet('pbmc68k_reduced')
- 11.7±0.07s 3.28±0.2s 0.28 preprocessing_counts.time_scrublet('pbmc3k')
- 2.48±0s 407±100ms 0.16 preprocessing_counts.time_scrublet('pbmc68k_reduced')
- 639M 527M 0.83 preprocessing_log.peakmem_pca('pbmc3k')

Comparison: https://github.com/scverse/scanpy/compare/19a0bb8fd3601c3b39e242ff6419fb73e59cf67a..0e14441111e310d30d8bd539062093f9b640e29c
Last changed: Tue, 14 May 2024 10:15:55 +0000

More details: https://github.com/scverse/scanpy/pull/3056/checks?check_run_id=24941793644

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.27%. Comparing base (19a0bb8) to head (0e14441).

Additional details and impacted files
@@            Coverage Diff             @@
##           1.10.x    #3056      +/-   ##
==========================================
- Coverage   76.27%   76.27%   -0.01%     
==========================================
  Files         117      117              
  Lines       12799    12803       +4     
==========================================
+ Hits         9763     9766       +3     
- Misses       3036     3037       +1     
Files Coverage Δ
scanpy/preprocessing/_highly_variable_genes.py 95.60% <100.00%> (ø)
scanpy/preprocessing/_scrublet/core.py 92.90% <100.00%> (+0.14%) ⬆️
scanpy/preprocessing/_simple.py 87.28% <100.00%> (ø)
scanpy/preprocessing/_scrublet/__init__.py 96.70% <0.00%> (-1.08%) ⬇️
scanpy/tools/_rank_genes_groups.py 94.33% <50.00%> (ø)

@flying-sheep flying-sheep merged commit dea050f into scverse:1.10.x May 14, 2024
11 of 12 checks passed
@flying-sheep flying-sheep mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants