-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend benchmarks from basic tutorial #3031
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 76.27% 76.27% -0.01%
==========================================
Files 117 117
Lines 12799 12803 +4
==========================================
+ Hits 9763 9766 +3
- Misses 3036 3037 +1
|
9954c43
to
de2ae21
Compare
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/d2a53680e312835b998077b4e25b254e98bcb5ba..69f9781b5ae3970d735c3b68879a791164d6a54d More details: https://github.com/scverse/scanpy/pull/3031/checks?check_run_id=24903996679 |
Oof, half an hour is definitely too long. I wonder why it takes that long. I can finish this up on friday |
@flying-sheep Not sure. Now that you mention it, the rapids benchmark also takes more time than I'd expect as well...The functions themselves are quite fast. |
Co-authored-by: Philipp A <[email protected]>
I added a sparse dataset to cover more code paths in most benchmarks.
regress_out
seems pretty slow with sparse data, maybe that should be tackled instead of hidden by disabling the benchmark.