Add admin to WasmMsg::Instantiate #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash is a String not &str
|
Thanks! I'm afraid that's a bug that we'll need to fix in a future upgrade. 😢 |
luca992
added a commit
to luca992/SecretNetwork
that referenced
this pull request
Sep 26, 2023
Damn, I kinda need this at least on testnet :/. I looked in the SecretNetwork repo and found the rust types there were also missing the admin param, add them in a pr. Not sure if other additional work is needed as I can't build it on my mac. But that's probably the most I can help. |
|
Thanks @luca992! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied to match upstream:
https://github.com/CosmWasm/cosmwasm/blob/09555ac1295f1f9129fd1fa5139d19763d16d2a1/packages/std/src/results/cosmos_msg.rs#L159C8-L159C8
Also, fixes setting mock_env hash.
However, I am testing it out in my example contract, and setting admin from rust does not appear to be working. Is there maybe some reason the admin param wouldn't be read automatically on the GO side? ... It very well could be a mistake on my side, I'm still testing it out. I'm using a local secret v1.11.0 instance
here's where I'm setting it for reference:
https://github.com/eqoty-labs/snip721-migratable/blob/aea67604348f29d779172abb803cf6e0cee5f52e/contracts/snip721-dealer/src/contract.rs#L77
@assafmo