Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin to WasmMsg::Instantiate (v1.12) #1546

Closed
wants to merge 2 commits into from

Conversation

luca992
Copy link
Contributor

@luca992 luca992 commented Sep 26, 2023

I don't have a setup that allows me to build this on arm64 but I am guessing this is the issue? @assafmo

Related: scrtlabs/cosmwasm#25

@assafmo
Copy link
Member

assafmo commented Sep 26, 2023

Yes! And also here

type InstantiateMsg struct {
// CodeID is the reference to the wasm byte code as used by the Cosmos-SDK
CodeID uint64 `json:"code_id"`
// Custom addition to support binding a message to specific code to harden against offline & replay attacks
// This is only needed when creating a callback message
CallbackCodeHash string `json:"callback_code_hash"`
// Msg is assumed to be a json-encoded message, which will be passed directly
// as `userMsg` when calling `Handle` on the above-defined contract
Msg []byte `json:"msg"`
/// Label is a mandatory human-readbale label for the contract
Label string `json:"label"`
// Send is an optional amount of coins this contract sends to the called contract
Send types.Coins `json:"send"`
CallbackSignature []byte `json:"callback_sig"` // Optional
}
should fix the issue

@luca992
Copy link
Contributor Author

luca992 commented Sep 26, 2023

Added a param there. But I'm guessing some other work needs to be done in lib.go however, I really don't even know go.. I'll have to let you guys handle that haha. Feel free to trash this pr if you want, I just was pointing out where I thought needed to be fixed

@assafmo
Copy link
Member

assafmo commented Sep 26, 2023

Thanks! We'll take it from here ♥️

@assafmo assafmo changed the title Add admin to WasmMsg::Instantiate Add admin to WasmMsg::Instantiate (v1.12) Sep 26, 2023
@assafmo
Copy link
Member

assafmo commented Sep 26, 2023

https://forum.scrt.network/t/an-update-on-bugs-with-the-v1-11-upgrade/7107

@assafmo
Copy link
Member

assafmo commented Sep 28, 2023

Continued in #1552

@assafmo assafmo closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants