Stop all sounds in the sound bank in stopAllSounds #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #2320
Proposed Changes
stopAllSoundsno longer uses_stopAllSoundsForTarget, instead it stops all sounds in the soundBank (by passing no arguments to SoundBank.stopAllSounds).Reason for Changes
Because of some weird clone handlings, SoundBank.playerTargets can contain targets that are no longer in runtime.targets, so sometimes sounds become unstoppable.
SoundBank.stopAllSoundstake an optional argument, and if passed (current behavior) only the specified target will have sounds stopped. However, this isn't necessary at all - it's expected to stop every sounds in every targets when VM's stopAllSounds is called.Test Coverage
Manually tested with GUI+VM