Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sounds can't be stopped if it's playing on already-deleted clones #2320

Open
apple502j opened this issue Feb 7, 2020 · 4 comments · May be fixed by #2351
Open

Sounds can't be stopped if it's playing on already-deleted clones #2320

apple502j opened this issue Feb 7, 2020 · 4 comments · May be fixed by #2351
Labels
bug priority 4

Comments

@apple502j
Copy link
Contributor

apple502j commented Feb 7, 2020 •
edited
Loading

Expected Behavior

Stop button, stop [all v] or stop all sounds blocks should all stop the sounds playing.

Actual Behavior

This script puts the sound into the "unstoppable" state.
image

Steps to Reproduce

See above.

Operating System and Browser

Firefox 72.0.2, Windows 10

Original report by Vadik1 on BaG forum, unknown environment

Maybe Related

#991 #949 and #1632
@qucchia
Copy link

qucchia commented Apr 17, 2020

This seems to be fixed now.

@apple502j apple502j changed the title Creating clone that plays a sound and immediately deletes itself while playing that sound will make the sound unstoppable Creating clone that plays a sound and immediately deletes itself will make the sound unstoppable Apr 17, 2020
@apple502j apple502j changed the title Creating clone that plays a sound and immediately deletes itself will make the sound unstoppable Creating clone that plays a sound and immediately deletes itself while playing that sound will make the sound unstoppable Apr 17, 2020
@apple502j
Copy link
Contributor Author

@qucchia It's still not fixed; on FF75 Windows 10

@apple502j
Copy link
Contributor Author

Also found a similar bug:
image

@apple502j apple502j changed the title Creating clone that plays a sound and immediately deletes itself while playing that sound will make the sound unstoppable Sounds can't be stopped if it's playing on already-deleted clones Apr 17, 2020
@apple502j
Copy link
Contributor Author

This happens if both

  1. sound is playing when the clone is deleted
  2. the clone is already deleted when the stop action is performed

@apple502j apple502j linked a pull request Apr 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop all sounds in the sound bank in stopAllSounds apple502j/scratch-vm
3 participants
@BryceLTaylor @apple502j @qucchia