Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run DAP for test suites in Metals #6551

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: run DAP for test suites in Metals #6551

merged 1 commit into from
Jul 3, 2024

Conversation

kasiaMarek
Copy link
Contributor

No description provided.

@kasiaMarek kasiaMarek mentioned this pull request Jun 28, 2024
Closed
@kasiaMarek kasiaMarek force-pushed the debug-adapter-for-tests branch from 02b3111 to aefe215 Compare June 28, 2024 13:18
@kasiaMarek kasiaMarek marked this pull request as ready for review June 28, 2024 14:28
@kasiaMarek kasiaMarek requested a review from tgodzik June 28, 2024 14:28
tgodzik
tgodzik reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! One main question about semanticdb, maybe it would be better to use it instead of delegating to the compiler?

metals/src/main/scala/scala/meta/internal/metals/debug/DebugProvider.scala Show resolved Hide resolved
mtags-interfaces/src/main/java/scala/meta/pc/PcSymbolInformation.java Show resolved Hide resolved
tgodzik
tgodzik approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! I think we should be good then!

@tgodzik tgodzik merged commit 093989e into scalameta:main Jul 3, 2024
24 checks passed
@kasiaMarek kasiaMarek mentioned this pull request Jul 15, 2024
Merged
tgodzik added a commit to scala/scala3 that referenced this pull request Jul 25, 2024
@tgodzik
Backport from metals (#21196)
dec395b 
contains:
scalameta/metals#6583

scalameta/metals#6575

scalameta/metals#6551

scalameta/metals#6498
scalameta/metals#6541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasiaMarek @tgodzik