Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport from metals #21196

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Backport from metals #21196

merged 6 commits into from
Jul 25, 2024

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek requested a review from tgodzik July 15, 2024 16:20
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Looks like something changed and the code doesn't compile

args.head
case t => t
singletonValues = collectSingletons(tpe).map(_.show)
range = completionPos.originalCursorPosition.withStart(span.start).withEnd(span.start + query.length).toLsp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not compiling

@kasiaMarek kasiaMarek requested a review from tgodzik July 25, 2024 15:07
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit dec395b into scala:main Jul 25, 2024
28 checks passed
WojciechMazur added a commit that referenced this pull request Aug 27, 2024
Backports #21196 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
WojciechMazur added a commit that referenced this pull request Dec 3, 2024
Backports #21196 to the 3.3.5.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants