-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport from metals #21196
Backport from metals #21196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Looks like something changed and the code doesn't compile
args.head | ||
case t => t | ||
singletonValues = collectSingletons(tpe).map(_.show) | ||
range = completionPos.originalCursorPosition.withStart(span.start).withEnd(span.start + query.length).toLsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not compiling
ae2a31f
to
875af44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Backports #21196 to the 3.5.2 branch. PR submitted by the release tooling. [skip ci]
Backports #21196 to the 3.3.5. PR submitted by the release tooling. [skip ci]
contains:
scalameta/metals#6583
scalameta/metals#6575
scalameta/metals#6551
scalameta/metals#6498
scalameta/metals#6541