Simplify defn.FunctionOf.unapply
#18486
Conversation
nicolasstucki
force-pushed
the
simplify-defn.FunctionOf.unapply
branch
from
91615cb to
fe74fb4
Compare
nicolasstucki
force-pushed
the
simplify-defn.FunctionOf.unapply
branch
from
fe74fb4 to
b640754
Compare
| defn.FunctionOf(paramtpe.forceBoxStatus(true) :: Nil, restpe, isContextual) | ||
|
|
||
| mapArgUsing: tp => | ||
| val defn.FunctionOf(paramtpe :: Nil, restpe, isContextual) = tp.strippedDealias: @unchecked |
There was a problem hiding this comment.
In the previous and current implementations, we need to strip the capture set from tp to get to the underlying function type. Is this intended, or are we losing part of the capture set that the resulting function needs?
There was a problem hiding this comment.
I also noticed that previously we stripped the capture set in FunctionOf for FunctionN but not for PolyFunction. This inconsistency could have been noticed on functions with erased parameters. Now we do not strip capture sets in any of the cases in FunctionOf.
nicolasstucki
force-pushed
the
simplify-defn.FunctionOf.unapply
branch
from
3694bae to
a083a7a
Compare
| @@ -1116,16 +1116,13 @@ class Definitions { | |||
| else | |||
| FunctionType(args.length, isContextual).appliedTo(args ::: resultType :: Nil) | |||
| def unapply(ft: Type)(using Context): Option[(List[Type], Type, Boolean)] = { | |||
| ft.dealias match | |||
There was a problem hiding this comment.
What is the reason to drop the dealias in the extractor?
There was a problem hiding this comment.
There are a few reasons:
- There are few places where that type is not already dealiased
- In a few cases we used to repeatedly dealias the type in pattern match extractors for functions. Not dealiassing here forces the use site to dealias a single time. Sometimes this happens in cases of a single pattern match and sometimes in the recursion of a
TypeMap. - This aligns the implementation closer to
RefinedFunctionOf,PolyFunctionOfandFunctionTypeOfMethod(in Handle dependent context functions #18443). - It brings us one step closer to being able to have a
derivedFunctionTypeOfmethod.
There was a problem hiding this comment.
OK, I agree it's good to align the unapply's towards no dealising.
nicolasstucki
force-pushed
the
simplify-defn.FunctionOf.unapply
branch
from
a083a7a to
171773d
Compare
No description provided.