Handle dependent context functions #18443
Conversation
nicolasstucki
force-pushed
the
handle-dependent-context-functions
branch
from
0f39f38 to
408c92c
Compare
| */ | ||
| def unapply(ft: Type)(using Context): Option[MethodOrPoly] = { | ||
| ft match | ||
| case RefinedType(parent, nme.apply, mt: MethodOrPoly) |
There was a problem hiding this comment.
I'd try to optimize it further by inlining the FunctionOf extractor and specializing it to this use case.
Also, maybe split the RefinedType match into two, one for MethodType refinements and the other for PolyType refinements?
There was a problem hiding this comment.
maybe split the RefinedType match into two, one for MethodType refinements and the other for PolyType refinements?
We would end up with these cases
ft match
case RefinedType(parent, nme.apply, mt: MethodType)
if parent.derivesFrom(defn.PolyFunctionClass) || isFunctionNType(parent) =>
Some(mt)
case RefinedType(parent, nme.apply, pt: PolyType)
if parent.derivesFrom(defn.PolyFunctionClass) =>
Some(mt)
...Note that in both cases we can have PolyFunctionClass because we now use PolyFunction for function types with erased parameters.
If it is for performance, we could do
ft match
case RefinedType(parent, nme.apply, mt: MethodOrPoly)
if parent.derivesFrom(defn.PolyFunctionClass) || (mt.isInstanceOf[MethodType] && isFunctionNType(parent)) =>
Some(mt)
...I pushed this last option.
nicolasstucki
force-pushed
the
handle-dependent-context-functions
branch
from
408c92c to
4df0b57
Compare
nicolasstucki
force-pushed
the
handle-dependent-context-functions
branch
from
65f6dfa to
12f5442
Compare
|
@nicolasstucki Can you have a look at the test failure? happy to review again when it is green. |
Add `FunctionTypeOfMethod` extractor that matches any kind of function
and return its method type.
We use this extractor instead of `ContextFunctionType` to all of
* `ContextFunctionN[...]`
* `ContextFunctionN[...] { def apply(using ...): R }` where `R` might
be dependent on the parameters.
* `PolyFunction { def apply(using ...): R }` where `R` might
be dependent on the parameters. Currently this one would have at
least one erased parameter.
nicolasstucki
force-pushed
the
handle-dependent-context-functions
branch
from
12f5442 to
d5d8273
Compare
|
@odersky now the CI passed. |
Add
FunctionTypeOfMethodextractor that matches any kind of function and return its method type.We use this extractor instead of
ContextFunctionTypeto all ofContextFunctionN[...]ContextFunctionN[...] { def apply(using ...): R }whereRmight be dependent on the parameters.PolyFunction { def apply(using ...): R }whereRmight be dependent on the parameters. Currently this one would have at least one erased parameter.The naming of the extractor follows the idea in #18305 (comment).