Rollup of 10 pull requests #96824
Merged
Rollup of 10 pull requests #96824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously linked to the unstable const-mut-cast method instead of the `mut` counterpart for `as_ref`.
The security example shows that `env::current_exe` will return the path used when the program was started. This is not really surprising considering how hard links work: after `ln foo bar`, the two files are _equivalent_. It is _not_ the case that `bar` is a “link” to `foo`, nor is `foo` a link to `bar`. They are simply two names for the same underlying data. The security vulnerability linked to seems to be different: there an attacker would start a SUID binary from a directory under the control of the attacker. The binary would respawn itself by executing the program found at `/proc/self/exe` (which the attacker can control). This is a real problem. In my opinion, the example given here doesn’t really show the same problem, it just shows a misunderstanding of what hard links are. I looked through the history a bit and found that the example was introduced in rust-lang#33526. That PR actually has two commits, and the first (8478d48) explains the race condition at the root of the linked security vulnerability. The second commit proceeds to replace the explanation with the example we have today. This commit reverts most of the second commit from rust-lang#33526.
This happened because the `SYSROOT` variable was set for `x test`, but not `x build`. Set it consistently for both to avoid unnecessary rebuilds.
The feature was stabilized in rust-lang#93745
`run-pass` produces a JSON file when enabling save analysis.
…-ptr-as_ref, r=JohnTitor Link to correct `as_mut` in docs for `pointer::as_ref` It previously linked to the unstable const-mut-cast method instead of the `mut` counterpart for `as_ref`. Closes rust-lang#96327
Add aliases for std::fs::canonicalize The aliases are `realpath` and `GetFinalPathNameByHandle` which are explicitly mentioned in `canonicalize`'s documentation.
…k-Simulacrum Add regression test fixes rust-lang#69785 This issue seems to have been fixed in the meantime.
…ark-Simulacrum Remove hard links from `env::current_exe` security example The security example shows that `env::current_exe` will return the path used when the program was started. This is not really surprising considering how hard links work: after `ln foo bar`, the two files are _equivalent_. It is _not_ the case that `bar` is a “link” to `foo`, nor is `foo` a link to `bar`. They are simply two names for the same underlying data. The security vulnerability linked to seems to be different: there an attacker would start a SUID binary from a directory under the control of the attacker. The binary would respawn itself by executing the program found at `/proc/self/exe` (which the attacker can control). This is a real problem. In my opinion, the example given here doesn’t really show the same problem, it just shows a misunderstanding of what hard links are. I looked through the history a bit and found that the example was introduced in rust-lang#33526. That PR actually has two commits, and the first (rust-lang@8478d48) explains the race condition at the root of the linked security vulnerability. The second commit proceeds to replace the explanation with the example we have today. This commit reverts most of the second commit from rust-lang#33526.
…Simulacrum Add regression and bug tests this tracks the behaviour from rust-lang#96572 in our test suite
…k-Simulacrum Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles I had this overridden locally for a while and realized just now it should probably just be a default.
…k-Simulacrum Don't constantly rebuild clippy on `x test src/tools/clippy`. This happened because the `SYSROOT` variable was set for `x test`, but not `x build`. Set it consistently for both to avoid unnecessary rebuilds. This is a very small step towards rust-lang#76495.
…m-active, r=joshtriplett Remove `adx_target_feature` feature from active features list The feature was stabilized in rust-lang#93745
…ysis, r=Mark-Simulacrum Make the test `check-pass` not to produce a JSON file `run-pass` produces a JSON file when enabling save analysis. The original ICE happened on `cargo check`, moreover **without** the `generic_const_exprs` feature, so `check-pass` should be enough.
…riddle Enforce quote rule for JS source code We mostly used double quotes but still had a weird mix. This eslint rule will now enforce it. r? `@notriddle`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=10 |
|
📌 Commit 20ade86 has been approved by |
bors
added
the
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e612ce9): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
as_mutin docs forpointer::as_ref#96336 (Link to correctas_mutin docs forpointer::as_ref)env::current_exesecurity example #96671 (Remove hard links fromenv::current_exesecurity example)compiler,codegen, andtoolsprofiles #96756 (Enable compiler-docs by default forcompiler,codegen, andtoolsprofiles)x test src/tools/clippy. #96757 (Don't constantly rebuild clippy onx test src/tools/clippy.)adx_target_featurefeature from active features list #96769 (Removeadx_target_featurefeature from active features list)check-passnot to produce a JSON file #96777 (Make the testcheck-passnot to produce a JSON file)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup