Don't constantly rebuild clippy on x test src/tools/clippy.
#96757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened because the `SYSROOT` variable was set for `x test`, but not `x build`. Set it consistently for both to avoid unnecessary rebuilds.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 101f952 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#96336 (Link to correct `as_mut` in docs for `pointer::as_ref`) - rust-lang#96586 (Add aliases for std::fs::canonicalize) - rust-lang#96667 (Add regression test) - rust-lang#96671 (Remove hard links from `env::current_exe` security example) - rust-lang#96726 (Add regression and bug tests) - rust-lang#96756 (Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles) - rust-lang#96757 (Don't constantly rebuild clippy on `x test src/tools/clippy`.) - rust-lang#96769 (Remove `adx_target_feature` feature from active features list) - rust-lang#96777 (Make the test `check-pass` not to produce a JSON file) - rust-lang#96822 (Enforce quote rule for JS source code) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@rustbot label +A-test-invalid-label |
|
Looks like rust-lang/triagebot#1610 is not working :( @Mark-Simulacrum do you mind checking the logs to see if triagebot threw an exception? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because the
SYSROOTvariable was set forx test, but notx build.Set it consistently for both to avoid unnecessary rebuilds.
This is a very small step towards #76495.