-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Remove doc link resolution fallback to all macro_rules
in the crate
#96676
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,23 @@ | ||
error: `str` is both a builtin type and a macro | ||
--> $DIR/macro-rules-error.rs:17:6 | ||
error: unresolved link to `before_but_limited_to_module` | ||
--> $DIR/macro-rules-error.rs:13:6 | ||
| | ||
LL | /// [str] FIXME: This error shouldn not be reported | ||
| ^^^ ambiguous link | ||
LL | /// [before_but_limited_to_module] | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `before_but_limited_to_module` in scope | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/macro-rules-error.rs:5:9 | ||
| | ||
LL | #![deny(rustdoc::broken_intra_doc_links)] | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
help: to link to the builtin type, prefix with `prim@` | ||
= note: `macro_rules` named `before_but_limited_to_module` exists in this crate, but it is not in scope at this link's location | ||
|
||
error: unresolved link to `after` | ||
--> $DIR/macro-rules-error.rs:15:6 | ||
| | ||
LL | /// [prim@str] FIXME: This error shouldn not be reported | ||
| +++++ | ||
help: to link to the macro, add an exclamation mark | ||
LL | /// [after] | ||
| ^^^^^ no item named `after` in scope | ||
| | ||
LL | /// [str!] FIXME: This error shouldn not be reported | ||
| + | ||
= note: `macro_rules` named `after` exists in this crate, but it is not in scope at this link's location | ||
|
||
error: aborting due to previous error | ||
error: aborting due to 2 previous errors | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FIXME is no longer relevant after #96187 as I understand, so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Thanks for the cleanup!