-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Remove doc link resolution fallback to all macro_rules
in the crate
#96676
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try |
⌛ Trying commit 27f0349f6a579e74d1c1e2bade8ff093b7879135 with merge 6fd27704e643b25711e6a97ec2b04873b411b97d... |
☀️ Try build successful - checks-actions |
@craterbot run mode=rustdoc |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
There's a huge number of spurious regressions, but 190 regressions are indeed due to the removal of the I think I have a plan for addressing this:
As a result we only break crates that explicitly deny |
Marking this as blocked on #96345 because the plan is hard to implement without a preparational cleanup. |
@@ -1826,11 +1805,22 @@ fn resolution_failure( | |||
diag.note(¬e); | |||
} | |||
|
|||
// If the link has `::` in it, assume it was meant to be an intra-doc link. | |||
// Otherwise, the `[]` might be unrelated. | |||
// FIXME: don't show this for autolinks (`<>`), `()` style links, or reference links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FIXME is no longer relevant after #96187 as I understand, so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Thanks for the cleanup!
PR updated in accordance with the plan from #96676 (comment). |
Thanks! @bors r+ |
📌 Commit b4019de has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c52b9c1): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
831: Add spin loop hints in tests for Miri r=taiki-e a=cbeuw This is a better way to do #829 Miri does not have a pre-emptive scheduler, so once the execution falls into a spin loop it'll hang forever: rust-lang/miri#1388 Similar measures (`yield_now()`) are already present in [some other tests](https://github.com/crossbeam-rs/crossbeam/blob/master/crossbeam-queue/tests/array_queue.rs), but it's missing here 832: Fix links to macro rules in docs r=taiki-e a=alygin The fix provides explicit links to macro rules in docs because they [are not resolved globally anymore](rust-lang/rust#96676). Co-authored-by: Andy Wang <[email protected]> Co-authored-by: Andrew Lygin <[email protected]>
Fallback to all
macro_rules
in the crate is removed, as discussed in #96521, with compatibility measures described in #96676 (comment).