parse_tt cleanups
#94547
Merged
parse_tt cleanups
#94547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=always |
This comment has been minimized.
This comment has been minimized.
|
r=me after updating the formatting. |
petrochenkov
added
S-waiting-on-author
|
I have retriggered the tests. There were no formatting problems locally, and the output of the failure didn't match the file contents... not sure what happened. |
To avoid the strange style where comments force `else` onto its own line. The commit also removes several else-after-return constructs, which can be hard to read.
There are three `Option` fields in `MatcherPos` that are only used in tandem. This commit combines them, making the code slightly easier to read. (It also makes clear that the `sep` field arguably should have been `Option<Option<Token>>`!)
Because `inner_parse_loop` has only one way to not succeed, not three.
|
Ah... I've occasionally had problems where a particular file doesn't get formatted by |
nnethercote
force-pushed
the
parse_tt-cleanups
branch
from
5100555 to
97eb1b4
Compare
|
@bors r=petrochenkov |
|
📌 Commit 97eb1b4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
…trochenkov `parse_tt` cleanups I've been looking closely at this code, and saw some opportunities to improve its readability. r? `@petrochenkov`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
…trochenkov `parse_tt` cleanups I've been looking closely at this code, and saw some opportunities to improve its readability. r? `````@petrochenkov`````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 3, 2022
…trochenkov `parse_tt` cleanups I've been looking closely at this code, and saw some opportunities to improve its readability. r? ``````@petrochenkov``````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92697 (Use cgroup quotas for calculating `available_parallelism`) - rust-lang#94057 (improve comments for `simplify_type`) - rust-lang#94547 (`parse_tt` cleanups) - rust-lang#94550 (rustdoc: Add test for higher kinded functions generated by macros) - rust-lang#94551 (Doc: Fix use of quote instead of backstick in Adapter::map.) - rust-lang#94554 (Fix invalid lint_node_id being put on a removed stmt) - rust-lang#94555 (all: fix some typos) - rust-lang#94563 (Remove a unnecessary `..` pattern) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking closely at this code, and saw some opportunities to improve its readability.
r? @petrochenkov