ARM: Only allow using d16-d31 with asm! when supported by the target #94339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support can be determined by checking for the "d32" LLVM feature.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
nagisa
reviewed
Feb 27, 2022
| @@ -36,6 +36,7 @@ const ARM_ALLOWED_FEATURES: &[(&str, Option<Symbol>)] = &[ | |||
| // #[target_feature]. | |||
| ("thumb-mode", Some(sym::arm_target_feature)), | |||
| ("thumb2", Some(sym::arm_target_feature)), | |||
| ("d32", Some(sym::arm_target_feature)), | |||
There was a problem hiding this comment.
Hm, given that these three features seem to be fated to remain unstable, maybe a different feature gate would be warranted for these?
There was a problem hiding this comment.
The 32-bit ARM features are bit of a mess and will need to be reworked anyways before stabilization can be considered.
nagisa
approved these changes
Feb 27, 2022
There was a problem hiding this comment.
r=me with or without feature gate rename. We can consider different feature gate later when its time to stabilize 32-bit arm features, but in that case maybe we should have a test that ensures d32 is feature-gated with a comment inside that this should never be ungated?
|
@bors r=nagisa |
|
📌 Commit 7cee1b4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 1, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? `@nagisa`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 2, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? ``@nagisa``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 2, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? ```@nagisa```
This was referenced Mar 2, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 2, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? ````@nagisa````
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? `````@nagisa`````
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 3, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? `````````@nagisa`````````
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
ARM: Only allow using d16-d31 with asm! when supported by the target Support can be determined by checking for the "d32" LLVM feature. r? `````````````@nagisa`````````````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#88805 (Clarification of default socket flags) - rust-lang#93418 (rustdoc & doc: no `shortcut` for `rel="icon"`) - rust-lang#93913 (Remove the everybody loops pass) - rust-lang#93965 (Make regular stdio lock() return 'static handles) - rust-lang#94339 (ARM: Only allow using d16-d31 with asm! when supported by the target) - rust-lang#94404 (Make Ord and PartialOrd opt-out in `newtype_index`) - rust-lang#94466 (bootstrap: correct reading of flags for llvm) - rust-lang#94572 (Use `HandleOrNull` and `HandleOrInvalid` in the Windows FFI bindings.) - rust-lang#94575 (CTFE SwitchInt: update comment) - rust-lang#94582 (Fix a bug in `x.py fmt` that prevents some files being formatted.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support can be determined by checking for the "d32" LLVM feature.
r? @nagisa