Update RELEASES.md for 1.49.0 #79815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
added
the
T-release
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Dec 8, 2020
alex
reviewed
Dec 8, 2020
Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Vadim Petrochenkov <[email protected]>
Co-authored-by: Jonas Schievink <[email protected]>
|
I think #78951 is missing from the compat notes - the list of targets can be obtained from the changed files (I believe the commits are separate so should be relatively easy to list them out). |
|
@Mark-Simulacrum It covers some but not all, as some of the changes are to the base target configuration such as |
|
Ah, ok. I think it should hopefully be possible to determine what uses those? I think a list of targets would be quite helpful for readers. |
|
@bors r+ squash rollup |
|
📌 Commit 481f6db has been approved by |
bors
added
S-waiting-on-bors
Closed
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 28, 2020
…Simulacrum Update RELEASES.md for 1.49.0 ### [Rendered](https://github.com/XAMPPRocky/rust/tree/relnotes-1.49.0/RELEASES.md) r? `@Mark-Simulacrum` cc `@rust-lang/release`
This was referenced Dec 28, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 28, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#79662 (Move some more code out of CodegenBackend::{codegen_crate,link}) - rust-lang#79815 (Update RELEASES.md for 1.49.0) - rust-lang#80284 (Suggest fn ptr rather than fn item and suggest to use `Fn` trait bounds rather than the unique closure type in E0121) - rust-lang#80331 (Add more comments to trait queries) - rust-lang#80344 (use matches!() macro in more places) - rust-lang#80353 (BTreeMap: test split_off (and append) more thoroughly) - rust-lang#80362 (Document rustc_macros on nightly-rustc) - rust-lang#80399 (Remove FIXME in rustc_privacy) - rust-lang#80408 (Sync rustc_codegen_cranelift) - rust-lang#80411 (rustc_span: Remove `Symbol::with`) - rust-lang#80434 (bootstrap: put the component name in the tarball temp dir path) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
jturner314
reviewed
Jan 2, 2021
|
|
||
| - [`RangeInclusive` now checks for exhaustion when calling `contains` and indexing.][78109] | ||
| - [`ToString::to_string` now no longer shrinks the internal buffer in the default implementation.][77997] | ||
| - [`ops::{Index, IndexMut}` are now implemented for fixed sized arrays of any length.][74989] |
There was a problem hiding this comment.
The changes in PR #74989 don't appear to be part of Rust 1.49.0, so I think this line should be removed.
(The impls in the PR itself say #[stable(feature = "index_trait_on_arrays", since = "1.50.0")], and I don't see them in the relevant file in the source code for the commit tagged 1.49.0.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release