-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Spans from HIR -- 2/N -- Small HIR nodes #73094
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @ghost , sorry |
☔ The latest upstream changes (presumably #72972) made this pull request unmergeable. Please resolve the merge conflicts. |
9965b8e
to
312c2fb
Compare
☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot modify labels to: +S-waiting-on-author -S-waiting-on-review |
☔ The latest upstream changes (presumably #74105) made this pull request unmergeable. Please resolve the merge conflicts. |
8615229
to
83d33e8
Compare
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
☔ The latest upstream changes (presumably #80253) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
778d77d
to
2fe8005
Compare
☔ The latest upstream changes (presumably #80364) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
2fe8005
to
fd78558
Compare
☔ The latest upstream changes (presumably #80439) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #77862) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot label: -S-waiting-on-review +S-waiting-on-author |
Triage: I'll mark this as blocked on #72878 for now. |
Second step in rust-lang/compiler-team#294
Builds on #72878
Split out of #72015
This PR gradually removes spans from HIR nodes with low usage.
Along the way, HIR visiting stops passing the spans to the visitor.