Implement Error::source on IntoStringError + Remove superfluous cause impls #65366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntoStringError only implemented Error::cause, which is deprecated. This implemements Error::source instead. Error::cause will still work as before, thanks to the default implementation.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This guess was wrong. |
faern
changed the title
|
Pushed two more commits. Removing |
bluss
reviewed
Oct 13, 2019
src/libstd/io/error.rs
Outdated
| Repr::Os(..) => None, | ||
| Repr::Simple(..) => None, | ||
| Repr::Custom(ref c) => c.error.cause(), | ||
| } |
There was a problem hiding this comment.
This risks being a noticeable change since we are calling out to a user-supplied .cause() vs .source() here.
There was a problem hiding this comment.
Good catch! I almost expected there was some aspect of this I missed 😅
I removed the last commit.
faern
force-pushed
the
source-on-intostringerror
branch
from
9c00e07 to
b8e7f76
Compare
|
@bors r+ rollup Thanks! |
|
📌 Commit b8e7f76 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
…bluss Implement Error::source on IntoStringError + Remove superfluous cause impls IntoStringError only implemented `Error::cause`, which is deprecated. This implemements `Error::source` instead. `Error::cause` will still work as before, thanks to the default implementation. I think this was the only/last `Error` impl in the standard library to have a cause, but not a source.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
…bluss Implement Error::source on IntoStringError + Remove superfluous cause impls IntoStringError only implemented `Error::cause`, which is deprecated. This implemements `Error::source` instead. `Error::cause` will still work as before, thanks to the default implementation. I think this was the only/last `Error` impl in the standard library to have a cause, but not a source.
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Rollup of 10 pull requests Successful merges: - #65214 (Split non-CAS atomic support off into target_has_atomic_load_store) - #65246 (vxWorks: implement get_path() and get_mode() for File fmt::Debug) - #65312 (improve performance of signed saturating_mul) - #65336 (Fix typo in task::Waker) - #65346 (nounwind tests and cleanup) - #65347 (Fix #[unwind(abort)] with Rust ABI) - #65366 (Implement Error::source on IntoStringError + Remove superfluous cause impls) - #65369 (Don't discard value names when using address or memory sanitizer) - #65370 (Add `dyn` to `Any` documentation) - #65373 (Fix typo in docs for `Rc`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntoStringError only implemented
Error::cause, which is deprecated. This implemementsError::sourceinstead.Error::causewill still work as before, thanks to the default implementation.I think this was the only/last
Errorimpl in the standard library to have a cause, but not a source.