improve performance of signed saturating_mul #65312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reciprocal throughput is improved from 2.3 to 1.7. https://godbolt.org/z/ROMiX6
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 57aae75 has been approved by |
bors
added
S-waiting-on-bors
|
The code I showed in the issue is equivalent to also changing |
dtolnay
approved these changes
Oct 11, 2019
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 57aae75 has been approved by |
|
r? @nagisa |
RalfJung
reviewed
Oct 11, 2019
| @@ -1058,7 +1058,7 @@ $EndFeature, " | |||
| #[inline] | |||
| pub fn saturating_mul(self, rhs: Self) -> Self { | |||
| self.checked_mul(rhs).unwrap_or_else(|| { | |||
| if (self < 0 && rhs < 0) || (self > 0 && rhs > 0) { | |||
| if (self < 0) == (rhs < 0) { | |||
There was a problem hiding this comment.
This is actually also more readable than before IMO, nice :)
There was a problem hiding this comment.
And in this case I think constness just has to wait :)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
improve performance of signed saturating_mul Reciprocal throughput is improved from 2.3 to 1.7. https://godbolt.org/z/ROMiX6 Fixes rust-lang#65309.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
improve performance of signed saturating_mul Reciprocal throughput is improved from 2.3 to 1.7. https://godbolt.org/z/ROMiX6 Fixes rust-lang#65309.
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Rollup of 10 pull requests Successful merges: - #65214 (Split non-CAS atomic support off into target_has_atomic_load_store) - #65246 (vxWorks: implement get_path() and get_mode() for File fmt::Debug) - #65312 (improve performance of signed saturating_mul) - #65336 (Fix typo in task::Waker) - #65346 (nounwind tests and cleanup) - #65347 (Fix #[unwind(abort)] with Rust ABI) - #65366 (Implement Error::source on IntoStringError + Remove superfluous cause impls) - #65369 (Don't discard value names when using address or memory sanitizer) - #65370 (Add `dyn` to `Any` documentation) - #65373 (Fix typo in docs for `Rc`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reciprocal throughput is improved from 2.3 to 1.7. https://godbolt.org/z/ROMiX6
Fixes #65309.