Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests around moving parts of structs and tuples across await points #63310

Merged
merged 1 commit into from
Aug 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/test/ui/async-await/move-part-await-return-rest-struct.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// build-pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this and the tests below could be check-pass

// edition:2018
// compile-flags: --crate-type lib

#![feature(async_await)]

struct Small {
x: Vec<usize>,
y: Vec<usize>,
}

// You are allowed to move out part of a struct to an async fn, you still
// have access to remaining parts after awaiting
async fn move_part_await_return_rest_struct() -> Vec<usize> {
let s = Small { x: vec![31], y: vec![19, 1441] };
needs_vec(s.x).await;
s.y
}

async fn needs_vec(_vec: Vec<usize>) {}
14 changes: 14 additions & 0 deletions src/test/ui/async-await/move-part-await-return-rest-tuple.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// build-pass
// edition:2018
// compile-flags: --crate-type lib

#![feature(async_await)]

async fn move_part_await_return_rest_tuple() -> Vec<usize> {
let x = (vec![3], vec![4, 4]);
drop(x.1);
echo(x.0[0]).await;
x.0
}

async fn echo(x: usize) -> usize { x }
19 changes: 19 additions & 0 deletions src/test/ui/async-await/no-move-across-await-struct.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// compile-fail
// edition:2018
// compile-flags: --crate-type lib

#![feature(async_await)]

async fn no_move_across_await_struct() -> Vec<usize> {
let s = Small { x: vec![31], y: vec![19, 1441] };
needs_vec(s.x).await;
s.x
//~^ ERROR use of moved value: `s.x`
}

struct Small {
x: Vec<usize>,
y: Vec<usize>,
}

async fn needs_vec(_vec: Vec<usize>) {}
13 changes: 13 additions & 0 deletions src/test/ui/async-await/no-move-across-await-struct.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
error[E0382]: use of moved value: `s.x`
--> $DIR/no-move-across-await-struct.rs:10:5
|
LL | needs_vec(s.x).await;
| --- value moved here
LL | s.x
| ^^^ value used here after move
|
= note: move occurs because `s.x` has type `std::vec::Vec<usize>`, which does not implement the `Copy` trait

error: aborting due to previous error

For more information about this error, try `rustc --explain E0382`.
15 changes: 15 additions & 0 deletions src/test/ui/async-await/no-move-across-await-tuple.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// compile-fail
// edition:2018
// compile-flags: --crate-type lib

#![feature(async_await)]

async fn no_move_across_await_tuple() -> Vec<usize> {
let x = (vec![3], vec![4, 4]);
drop(x.1);
nothing().await;
x.1
//~^ ERROR use of moved value: `x.1`
}

async fn nothing() {}
14 changes: 14 additions & 0 deletions src/test/ui/async-await/no-move-across-await-tuple.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
error[E0382]: use of moved value: `x.1`
--> $DIR/no-move-across-await-tuple.rs:11:5
|
LL | drop(x.1);
| --- value moved here
LL | nothing().await;
LL | x.1
| ^^^ value used here after move
|
= note: move occurs because `x.1` has type `std::vec::Vec<usize>`, which does not implement the `Copy` trait

error: aborting due to previous error

For more information about this error, try `rustc --explain E0382`.