Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librustc_driver => 2018 #58253

Merged
merged 1 commit into from
Mar 28, 2019
Merged

librustc_driver => 2018 #58253

merged 1 commit into from
Mar 28, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 7, 2019

Transitions librustc_driver to Rust 2018; cc #58099

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 5d65c19 to a982ce1 Compare February 7, 2019 06:41
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch 2 times, most recently from 548360e to 4fc9847 Compare February 7, 2019 15:48
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 4fc9847 to 0c49328 Compare February 8, 2019 06:49
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 0c49328 to 4708f78 Compare February 8, 2019 10:28
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e mentioned this pull request Feb 8, 2019
Merged
Centril
Centril approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo ICE

@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 4708f78 to 2ea02a8 Compare February 9, 2019 13:25
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 2ea02a8 to 8a58ccc Compare February 10, 2019 06:05
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 8a58ccc to 00b3271 Compare February 10, 2019 07:30
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril mentioned this pull request Feb 11, 2019
Closed
78 tasks
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 00b3271 to 9ea53dd Compare February 12, 2019 14:04
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e changed the title librustc_driver => 2018 [WIP] librustc_driver => 2018 Feb 12, 2019
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch 2 times, most recently from ab141d6 to 7720ffd Compare February 12, 2019 17:49
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from 7720ffd to 27c4bd8 Compare February 13, 2019 01:46
@taiki-e taiki-e changed the title [WIP] librustc_driver => 2018 librustc_driver => 2018 Feb 13, 2019
@petrochenkov petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 25, 2019
@Centril Centril mentioned this pull request Mar 26, 2019
Merged
bors added a commit that referenced this pull request Mar 26, 2019
@bors
Auto merge of #59434 - Centril:bootstrap-to-2019-03-20, r=Mark-Simula…
07d3508 
…crum

Bump bootstrap compiler to 2019-03-20

Includes #59295 and by extension #59047, which unblocks #58253, #58837, and possibly #59336, and so therefore:

@bors p=50

r? @Mark-Simulacrum

cc @pietroalbini
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 26, 2019
@Centril
Copy link
Contributor

Centril commented Mar 26, 2019

Bootstrap was changed in #59434. This should now be unblocked. @taiki-e mind rebasing + other needed changes?

@petrochenkov
Copy link
Contributor

@taiki-e
Could you also squash the commits together with rebase.

@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from d3474e1 to a62b3d6 Compare March 26, 2019 19:49
@taiki-e
Copy link
Member Author

taiki-e commented Mar 26, 2019

Rebased.

@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the librustc_driver-2018 branch from a62b3d6 to 24a0cae Compare March 26, 2019 20:40
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2019

📌 Commit 24a0cae has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#58253 - taiki-e:librustc_driver-2018, r=pet…
92f30a8 
…rochenkov

librustc_driver => 2018

Transitions `librustc_driver` to Rust 2018; cc rust-lang#58099

r? @Centril
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#58253 - taiki-e:librustc_driver-2018, r=pet…
290146c 
…rochenkov

librustc_driver => 2018

Transitions `librustc_driver` to Rust 2018; cc rust-lang#58099

r? @Centril
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#58253 - taiki-e:librustc_driver-2018, r=pet…
34f0297 
…rochenkov

librustc_driver => 2018

Transitions `librustc_driver` to Rust 2018; cc rust-lang#58099

r? @Centril
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019
@cuviper
Rollup merge of rust-lang#58253 - taiki-e:librustc_driver-2018, r=pet…
2a3c2bf 
…rochenkov

librustc_driver => 2018

Transitions `librustc_driver` to Rust 2018; cc rust-lang#58099

r? @Centril
@cuviper cuviper mentioned this pull request Mar 28, 2019
Merged
bors added a commit that referenced this pull request Mar 28, 2019
@bors
Auto merge of #59471 - cuviper:rollup, r=cuviper
d20e000 
Rollup of 18 pull requests

Successful merges:

 - #57293 (Make some lints incremental)
 - #57565 (syntax: Remove warning for unnecessary path disambiguators)
 - #58253 (librustc_driver => 2018)
 - #58837 (librustc_interface => 2018)
 - #59268 (Add suggestion to use `&*var` when `&str: From<String>` is expected)
 - #59283 (Make ASCII case conversions more than 4× faster)
 - #59284 (adjust MaybeUninit API to discussions)
 - #59372 (add rustfix-able suggestions to trim_{left,right} deprecations)
 - #59390 (Make `ptr::eq` documentation mention fat-pointer behavior)
 - #59393 (Refactor tuple comparison tests)
 - #59420 ([CI] record docker image info for reuse)
 - #59421 (Reject integer suffix when tuple indexing)
 - #59430 (Renames `EvalContext` to `InterpretCx`)
 - #59439 (Generalize diagnostic for `x = y` where `bool` is the expected type)
 - #59449 (fix: Make incremental artifact deletion more robust)
 - #59451 (Add `Default` to `std::alloc::System`)
 - #59459 (Add some tests)
 - #59460 (Include id in Thread's Debug implementation)

Failed merges:

r? @ghost
@bors bors merged commit 24a0cae into rust-lang:master Mar 28, 2019
@taiki-e taiki-e deleted the librustc_driver-2018 branch March 28, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@Centril Centril Centril approved these changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@taiki-e @rust-highfive @bors @Centril @petrochenkov @Dylan-DPC-zz