-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clippy #47172
Update clippy #47172
Conversation
Looks like CI may be failing b/c the lock file needs to be updated? Other than that r=me |
@bors r=alexcrichton p=3 (p+ for it to reach beta) |
📌 Commit ff1ecd4 has been approved by |
⌛ Testing commit ff1ecd4f612ee3789a4a7d72453d931573a5c96a with merge 8d138f932730e80517000cfcc8c220fd2e70b1c8... |
@Manishearth 1.24 beta has already been branched off, this PR won’t reach it unless we backport. |
Ah. Is is important for this PR to reach it? Or is it ok because we don't ship clippy with rustup yet? |
According to #47119 (comment) it is OK not to backport it because we don't ship clippy yet. |
💔 Test failed - status-travis |
@bors r=alexcrichton needed a compiletest bump |
📌 Commit aaf099e has been approved by |
💔 Test failed - status-travis |
Legit, test failed due to read-only filesystem. Looks like still the same error we've seen before at #46554 (comment)
|
Ping from triage, @Manishearth! Will you have time to address the reported issues in the near future? |
Not really, and I don't know what's going on. Perhaps @oli-obk does? |
☔ The latest upstream changes (presumably #47280) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks like this is replaced by #47557, so I'm closing! |
r? @kennytm @alexcrichton @oli-obk